Feat/allow enable disable sodium #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boorad
approved these changes
May 15, 2025
packages/react-native-quick-crypto/cpp/cipher/XSalsa20Cipher.hpp
Outdated
Show resolved
Hide resolved
Contributor
|
technically, if we disable sodium and run the example tests, they should fail, correct? |
Contributor
|
Looks like the env |
Contributor
|
Confirmed the failed test 
|
Contributor
Author
|
@renanmav Yes, the tests should fail and say one needs to enable sodium. |
renanmav
approved these changes
May 15, 2025
Contributor
There was a problem hiding this comment.
Pushed a small update on 5d5b156, that env is already overriden in the Podfile
react-native-quick-crypto/example/ios/Podfile
Lines 1 to 2 in 5d5b156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to enable/disable libsodium. Disabled by default. The reason is to avoid unnecessary size added to the library when one doesn't use the functionality that requires libsodium.
Android (gradle.properties):
iOS (Podfile)